Fix checks for worker classes in directly chained clusters #5936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consider all worker classes to verify that all jobs in a directly chained cluster have the same set of worker classes assigned * Avoid DBIx warning in case a job with directly chained dependencies has more than one worker class assigned * See https://progress.opensuse.org/issues/154735
* Consider all worker classes to verify that all jobs in a directly chained cluster have the same set of worker classes assigned * Avoid DBIx warning in case a job with directly chained dependencies has more than one worker class assigned * See https://progress.opensuse.org/issues/154735
Martchus
force-pushed
the
worker-class-comparison
branch
from
5c31cf6
to
31174dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5936 +/- ##
==========================================
- Coverage 98.74% 98.74% -0.01%
==========================================
Files 396 396
Lines 38870 38875 +5
==========================================
+ Hits 38384 38386 +2
- Misses 486 489 +3 ☔ View full report in Codecov by Sentry. |
perlpunk
reviewed
Sep 23, 2024
| @@ -6,6 +6,11 @@ use Mojo::Base 'DBIx::Class::ResultSet', -signatures; | |||
|
|
|||
| use OpenQA::App; | |||
|
|
|||
| sub all_values_sorted ($self, $job_id, $key) { | |||
| state $options = {distinct => 1, columns => 'value', order_by => 'value'}; | |||
There was a problem hiding this comment.
Why are you using state here?
There was a problem hiding this comment.
Because this hash never changes, so no need to re-initialize it on every function call. (That's probably the C++ programmer in me; in C++ that would be static const … and state is the closest Perl has to offer.)
There was a problem hiding this comment.
It's a bit uncommon for a simple, small hashref, but I won't complain
perlpunk
approved these changes
Sep 23, 2024
kalikiana
approved these changes
Sep 23, 2024
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Sep 24, 2024
commit 08dcad3 Merge: 6d38c3b 31174dc Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Mon Sep 23 15:40:50 2024 +0000 Commit: GitHub <[email protected]> CommitDate: Mon Sep 23 15:40:50 2024 +0000 Merge pull request os-autoinst#5936 from Martchus/worker-class-comparison Fix checks for worker classes in directly chained clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See particular commit messages and https://progress.opensuse.org/issues/154735