Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tidyall is available in CI after 28c5dd1 #5928

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Martchus
Copy link
Contributor

  • Ensure openQA-devel depends on perl(Code::TidyAll) so that package is
    available in the CI
  • Add the package only to style check dependencies (and not test
    dependencies) so the package build does not depend on it
  • See https://progress.opensuse.org/issues/166817

Note that I have already prepared a branch to merge os-autoinst/os-autoinst-common#55. For now I excluded this commit because we'll have to wait for the OBS package build on devel:openQA and the nightly job on CircleCI for this to become effective.

* Ensure `openQA-devel` depends on `perl(Code::TidyAll)` so that package is
  available in the CI
* Add the package only to style check dependencies (and not test
  dependencies) so the package build does not depend on it
* See https://progress.opensuse.org/issues/166817
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (f8960ee) to head (c7ddcb0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5928   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         395      395           
  Lines       38768    38768           
=======================================
  Hits        38279    38279           
  Misses        489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit b2c7833 into os-autoinst:master Sep 16, 2024
45 checks passed
@Martchus Martchus deleted the tidy-no-subrepo branch September 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants