Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude sub packages with many additional dependencies on SLE #5923

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Martchus
Copy link
Contributor

As stated in https://build.suse.de/request/show/343857#comment-4023273 not all sub packages are installable on SLE. This only concerns the devel and munin sub packages which are really optional. So it makes sense to avoid submitting a huge number of Haskell and Perl packages to SLE and exclude those packages instead.

Related ticket: https://progress.opensuse.org/issues/165683

@Martchus
Copy link
Contributor Author

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it make sense to exclude a devel package on SLE when we still want to build and test the package on SLE?

@Martchus
Copy link
Contributor Author

Martchus commented Sep 12, 2024

The devel package is not required to build and test the package. It only contains further dependencies such as Selenium/chromedriver and ShellCheck so one can install them conveniently to setup a local development environment. Note that during the package build Selenium and developer-facing tests using ShellCheck and further Perl dependencies are not executed and this is not SLE-specific.

As stated in https://build.suse.de/request/show/343857#comment-4023273 not
all sub packages are installable on SLE. This only concerns the `devel`
and `munin` sub packages which are really optional. So it makes sense to
avoid submitting a huge number of Haskell and Perl packages to SLE and
exclude those packages instead.

Related ticket: https://progress.opensuse.org/issues/165683
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But with package hub it would be possible to build those packages. I am not convinced we want to disable the build completely based on those conditions. Would it be possible to set/unset the condition variable in ibs project config? Or as a completely different alternative disable the build of selected sub packages in the according ibs projects?

@Martchus
Copy link
Contributor Author

Martchus commented Sep 12, 2024

Would it be possible to set/unset the condition variable in ibs project config? Or as a completely different alternative disable the build of selected sub packages in the according ibs projects?

I don't know. I would generally say that this is not possible because we are not in control of the project config where the final package will end up.

I think we should treat SLE as "pure SLE" in the spec file and not as "SLE plus package hub". If one wants to build those packages with package hub enabled they can still do so in a custom project and get the sub packages by adding the following to the project config:

Macros:
%_with_devel_package 1
%_with_munin_package 1
:Macros

@Martchus
Copy link
Contributor Author

Note that I also generally don't think these kinds of packages (or rather the dependencies they pull in) belong to something we should generally support on SLE. For instance, just because we want to add a cool new linter we shouldn't need to support that on SLE as well. Also supporting the Haskell stack (of which we as a team have probably very little experience with) is not the best idea.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot how the conditions work which still allow to set settings in projects so all is good then.

@mergify mergify bot merged commit f8960ee into os-autoinst:master Sep 16, 2024
48 checks passed
@Martchus Martchus deleted the conditional-spec-file branch September 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants