Move python3-yamllint from test to style-check dependencies
#5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Python module is only required by the `test-yaml` target which in turn is only invoked by style checks. So it makes sense to treat this dependency like the other dependencies of style checks. Related ticket: https://progress.opensuse.org/issues/165683
perlpunk
approved these changes
Aug 26, 2024
kalikiana
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5893 +/- ##
=======================================
Coverage 98.50% 98.51%
=======================================
Files 394 394
Lines 38754 38754
=======================================
+ Hits 38175 38178 +3
+ Misses 579 576 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Python module is only required by the
test-yamltarget which in turn is only invoked by style checks. So it makes sense to treat this dependency like the other dependencies of style checks.Related ticket: https://progress.opensuse.org/issues/165683