Fix invalid HTML leading to fullstack test failures #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of `code` tag within `select`/`option` to avoid new Chromium warning `A code tag was parsed inside of a <select> which was not inserted into the document.` that interferes with the fullstack test. Related ticket: https://progress.opensuse.org/issues/165764
baierjan
approved these changes
Aug 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5889 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 394 394
Lines 38735 38746 +11
=======================================
+ Hits 38158 38169 +11
Misses 577 577 ☔ View full report in Codecov by Sentry. |
perlpunk
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of
codetag withinselect/optionto avoid new Chromium warningA code tag was parsed inside of a <select> which was not inserted into the document.that interferes with the fullstack test.Related ticket: https://progress.opensuse.org/issues/165764