Avoid having RPM build depend on packages only needed for style checks #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPM builds do not execute style checks (also when `--with-tests` is used) so dependencies like ShellCheck should not be required for the build. This avoids pulling in a lot of transitive dependencies into the build and thus also greatly reduces the number of packages we need submit to SLE to build openQA on/for SLE. Related ticket: https://progress.opensuse.org/issues/165683
kalikiana
approved these changes
Aug 23, 2024
perlpunk
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPM builds do not execute style checks (also when
--with-testsis used) so dependencies like ShellCheck should not be required for the build.This avoids pulling in a lot of transitive dependencies into the build and thus also greatly reduces the number of packages we need submit to SLE to build openQA on/for SLE.
Related ticket: https://progress.opensuse.org/issues/165683