Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tour to drop problematic dependency #5861

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Remove tour to drop problematic dependency #5861

merged 2 commits into from
Aug 16, 2024

Commits on Aug 16, 2024

  1. Remove tour as it was rather obtrusive 

    * Remove tour dropping problematic dependency `shepherd.js`
* Keep the database column to avoid a problematic database migration
* Keep the API endpoint to set the tour progress to avoid a breaking API
  change
* Note that we might want to repurpose the database column and API in the
  future to show a simple help notification for new users
* Add a very small test for the feature API so it is still covered after
  removing the UI test of the feature tour
* Remove all UI code related to the tour
* See https://progress.opensuse.org/issues/163004 for further reasoning
    @Martchus
    Martchus committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7910906 View commit details
    Browse the repository at this point in the history

  2. Add better help on menu items after removing obtrusive tour 

    * Note that this little information is really all the tour provided; it
  might make sense to add further tooltips in the future
* Note that the jumptron already points out the most relevant documentation
  pages via our brandings
* See https://progress.opensuse.org/issues/163004
    @Martchus
    Martchus committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2560464 View commit details
    Browse the repository at this point in the history