Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t: Avoid tampering with git checkout #5857

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

perlpunk
Copy link
Contributor

I was running this test locally and it failed every second time, because it created some directory that wasn't cleaned up.

Now it copies everything it needs to a tempdir and leaves the source dir alone.

Related issue: https://progress.opensuse.org/issues/164883

t/14-grutasks.t Outdated Show resolved Hide resolved
t/14-grutasks.t Outdated Show resolved Hide resolved
t/14-grutasks.t Outdated Show resolved Hide resolved
t/14-grutasks.t Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (2972cfd) to head (6fb2c48).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5857   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         395      395           
  Lines       38753    38759    +6     
=======================================
+ Hits        38174    38180    +6     
  Misses        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I was running this test locally and it failed every second time,
because it created some directory that wasn't cleaned up.

Now it copies everything it needs to a tempdir and leaves the source dir alone.

Related issue: https://progress.opensuse.org/issues/164883
If the number changes, one often forgets to update the test label as well
@mergify mergify bot merged commit b24c267 into os-autoinst:master Aug 14, 2024
43 checks passed
@perlpunk perlpunk deleted the tempdir branch August 14, 2024 19:09
os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Aug 15, 2024
commit b24c267
Merge: 3f88197 6fb2c48
Author:     mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
AuthorDate: Wed Aug 14 18:34:45 2024 +0000
Commit:     GitHub <[email protected]>
CommitDate: Wed Aug 14 18:34:45 2024 +0000

    Merge pull request os-autoinst#5857 from perlpunk/tempdir

    t: Avoid tampering with git checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants