Fix cancelling any pending job from /tests/overview #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @perlpunk found out jobs in "uploading" state can be cancelled from the tests details page but not the overview page. Also the alignment of icons looks bad in that case as any row with a job in "uploading" shows neither the "retrigger" nor the "cancel" action. This commit fixes this problem for jobs in any "pending state" including not only "uploading" but also "assigned" or "setup". The change changes the explicit check for equality to a proper "any" check against the aggregate constant as we should be using anyway.
Martchus
approved these changes
Aug 6, 2024
kalikiana
approved these changes
Aug 6, 2024
perlpunk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @perlpunk found out jobs in "uploading" state can be cancelled from
the tests details page but not the overview page. Also the alignment of
icons looks bad in that case as any row with a job in "uploading" shows
neither the "retrigger" nor the "cancel" action. This commit fixes this
problem for jobs in any "pending state" including not only "uploading"
but also "assigned" or "setup". The change changes the explicit check for
equality to a proper "any" check against the aggregate constant as we
should be using anyway.
Visualization of the problem:
