Define single-instance container for Codespaces #5818
Conversation
|
Why don't you change https://github.com/os-autoinst/openQA/blob/master/container/single-instance/Dockerfile ? |
it is gonna be in part 2?! :) |
Not sure what exactly you mean, but that's likely against AC2 in the referenced ticket. |
| #!BuildTag: openqa-single-instance-codespaces:latest opensuse/openqa-single-instance-codespaces:latest opensuse/openqa-single-instance-codespaces:%PKG_VERSION% opensuse/openqa-single-instance-codespaces:%PKG_VERSION%.%RELEASE% | ||
|
|
||
| # hadolint ignore=DL3006 | ||
| FROM openqa-single-instance |
There was a problem hiding this comment.
isnt that a Leap? I thought that it should be a TW. should we have a comment? wdyt?
There was a problem hiding this comment.
It is Leap right now, but it will be Tumbleweed in a near future, see #5819.
There was a problem hiding this comment.
I just saw https://github.com/os-autoinst/openQA/pull/5819/files#diff-cd62a72c6c09ba757d9d23c56722b50b7c1b2e2da6a7a0c496c8a8e6e3ce8e9fR5. Still it would be nice to have a link to the container/single-instance/Dockerfile here?
|
|
||
| # install Codespaces requirements | ||
| # hadolint ignore=DL3037 | ||
| RUN zypper in -y awk tar && \ |
There was a problem hiding this comment.
Why not add those to the existing container? Seems like they would be useful anyway and we wouldn't need yet another container to maintain - and I wonder where to test this? openQA-in-openQA tests or somewhere else?
There was a problem hiding this comment.
See #5818 (comment)
It violates AC2 as discussed during the estimation (yes, I would also think adding just those basic tools wouldn't hurt, but the ticket says otherwise).
I do not know if codespaces containers can be tested automatically, for manual testing I guess just start the environment should do the trick (although it is unclear to me if I can do that without changing the devcontainer definition).
There was a problem hiding this comment.
testing codespaces is a bit cumbersome. you would need to branch the obs project (and enable publishing) and then in your github fork in the devcontainer point to the container from your fork.
There was a problem hiding this comment.
regarding awk and tar - The downside of having two containers is that it makes it even harder to test any changes, so I personally would vote against AC2.
Reference: https://progress.opensuse.org/issues/161399
This is part 1.