Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jobs running without needing to set needles URL specifically #5804

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Make jobs running without needing to set needles URL specifically #5804

merged 1 commit into from
Aug 7, 2024

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Jul 30, 2024 •
edited
Loading

As per https://progress.opensuse.org/issues/162632, openqa-clone-custom-git-refspec might fail in case NEEDLES_DIR is set and contains an absolute path which directs to the pool. Also in contrast of the poo's suggestion there is no change in removal of the vars.json logic.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master https://openqa.opensuse.org/tests/4368385
1 job has been created:
 - microos-Tumbleweed-DVD-x86_64-Build20240730-fips-container-host@64bit -> https://openqa.opensuse.org/tests/4369552

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4360621  
1 job has been created:
 - openqa-Tumbleweed-dev-x86_64-Build:TW.30160-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4369553

@b10n1k b10n1k force-pushed the 162632_clone_script branch 2 times, most recently from 4a88e1b to 776bd58 Compare July 30, 2024 21:58
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (fffb458) to head (ad62032).
Report is 41 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5804      +/-   ##
==========================================
- Coverage   98.49%   98.49%   -0.01%     
==========================================
  Files         394      394              
  Lines       38688    38686       -2     
==========================================
- Hits        38104    38102       -2     
  Misses        584      584

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b10n1k b10n1k force-pushed the 162632_clone_script branch 2 times, most recently from 2a99fc2 to e8fc083 Compare July 31, 2024 07:33
okurz
okurz requested changes Jul 31, 2024
View reviewed changes
script/openqa-clone-custom-git-refspec Outdated Show resolved Hide resolved
t/40-script_openqa-clone-custom-git-refspec.t Outdated Show resolved Hide resolved
@b10n1k b10n1k force-pushed the 162632_clone_script branch 2 times, most recently from a2098c7 to 0e4b252 Compare July 31, 2024 09:11
@b10n1k b10n1k force-pushed the 162632_clone_script branch 2 times, most recently from a66afff to 4704d76 Compare August 1, 2024 11:06
okurz

This comment was marked as resolved.

Sign in to view

Martchus
Martchus reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

@b10n1k
Copy link
Contributor Author

b10n1k commented Aug 1, 2024

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1
1 job has been created:

@b10n1k

This comment was marked as resolved.

Sign in to view
@Martchus
Copy link
Contributor

Martchus commented Aug 1, 2024

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:

* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792

This looks good. Now try with an osado job to cover the case when NEEDLES_DIR is present in the job to be cloned.

@b10n1k
Copy link
Contributor Author

b10n1k commented Aug 2, 2024

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:

* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792

This looks good. Now try with an osado job to cover the case when NEEDLES_DIR is present in the job to be cloned.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master https://openqa.opensuse.org/tests/4368385 ADD_OPENQA_REPO=1
1 job has been created:

@Martchus
Copy link
Contributor

Martchus commented Aug 2, 2024

Ok, looks like all common cases just continue to work.

okurz
okurz requested changes Aug 2, 2024
View reviewed changes
t/40-script_openqa-clone-custom-git-refspec.t Outdated Show resolved Hide resolved
t/40-script_openqa-clone-custom-git-refspec.t Outdated Show resolved Hide resolved
@b10n1k
Make jobs running without needing to set needles URL specifically
ad62032 
As per https://progress.opensuse.org/issues/162632,
openqa-clone-custom-git-refspec might fail in case NEEDLES_DIR is set and
contains an absolute path which directs to the pool. However the NEEDLES_DIR
does not to be adjust as it is set once the job run.

Signed-off-by: ybonatakis <[email protected]>
@okurz okurz added the not-ready label Aug 5, 2024
okurz
okurz approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@okurz okurz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Please invite our common "beta testers" to try this out :)

EDIT: No reaction from SUSE power users

@mergify mergify bot merged commit 47d46aa into os-autoinst:master Aug 7, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlpunk perlpunk perlpunk left review comments

@Martchus Martchus Martchus left review comments

@kalikiana kalikiana kalikiana approved these changes

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@b10n1k @Martchus @perlpunk @kalikiana @okurz