worker: Provide a sensible default for "critical load threshold" #5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests need to be adjusted. |
okurz
force-pushed
the
feature/load_limit_default
branch
from
e88e342
to
34ed70d
Compare
|
sorry, merged implicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our experiences various issues with tests can appear if the system load is exceeding certain sane levels, for example typing issues such as mistyping, hanging keys, lost characters, but also various timeouts and even network outages.
This commit introduces a new default value enabling the recently introduced check for "critical load" on an openQA worker to prevent an openQA worker from starting new jobs until the system load is again below a threshold.
The value selection is of course based on empirical data gathered so far and can and should be tweaked if we know more.
Related progress issue: https://progress.opensuse.org/issues/158125