Fix race conditions when handling barriers #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Mar 13, 2024
* Avoid race condition when creating a barrier by using `ON CONFLICT DO NOTHING` like we already do for job networks * Avoid race conditions when waiting on and destroying barriers by calling update/delete on the search results (and not a single search result) so the update/deletion is just not affecting any rows instead of running into `row not found` * See https://progress.opensuse.org/issues/156754
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5510 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 391 391
Lines 37930 37930
=======================================
Hits 37318 37318
Misses 612 612 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Mar 14, 2024
perlpunk
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ON CONFLICT DO NOTHINGlike we already do for job networksupdate/delete on the search results (and not a single search result) so
the update/deletion is just not affecting any rows instead of running
into
row not foundThe handling of normal locks should probably be improved as well but is not covered here.