Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it less likely for jobs incompleting with Cache … queue … full #5500

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Mar 4, 2024

  • Introduce a hard-limit for inactive Minion jobs
  • Make the hard-limit slightly higher than the normal limit
  • Enforce only the hard-limit on openQA job setup; so when the normal Minion queue limit was reached after a job had already been picked-up it can still continue to create Minion jobs instead of ending up as incomplete
  • See https://progress.opensuse.org/issues/128276

Still a draft because tests are missing.

@Martchus Martchus marked this pull request as ready for review March 5, 2024 15:58
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (060eef3) to head (d27d56d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5500   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         391      391           
  Lines       37910    37926   +16     
=======================================
+ Hits        37298    37314   +16     
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be more points. Just had one question for a start. Will look into more later.

lib/OpenQA/CacheService/Response.pm Outdated Show resolved Hide resolved
* Introduce a hard-limit for inactive Minion jobs
* Make the hard-limit slightly higher than the normal limit
* Enforce only the hard-limit on openQA job setup; so when the normal
  Minion queue limit was reached after a job had already been picked-up it
  can still continue to create Minion jobs instead of ending up as
  incomplete
* See https://progress.opensuse.org/issues/128276
@mergify mergify bot merged commit 90519fe into os-autoinst:master Mar 7, 2024
42 checks passed
@Martchus Martchus deleted the cache-queue-hard-limit branch March 7, 2024 17:15
os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Mar 10, 2024
commit 90519fe
Merge: 8fc02ca d27d56d
Author:     mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
AuthorDate: Thu Mar 7 14:45:11 2024 +0000
Commit:     GitHub <[email protected]>
CommitDate: Thu Mar 7 14:45:11 2024 +0000

    Merge pull request os-autoinst#5500 from Martchus/cache-queue-hard-limit

    Make it less likely for jobs incompleting with `Cache … queue … full`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants