Simplify service_port_delta with environment variable

[okurz]

Related progress issue: https://progress.opensuse.org/issues/153499

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37fc220) 98.38% compared to head (87aec4d) 98.38%.
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5477   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         390      390           
  Lines       37862    37862           
=======================================
  Hits        37250    37250           
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[okurz]

CI failure sounds related but I don't understand it:

[15:26:28] t/33-developer_mode.t .. 19/?     # Unexpected Javascript console errors, waiting for connection opened: [
    #   {
    #     level     => "SEVERE",
    #     message   => "http://localhost:9526/asset/3906633cf0/ws_console.js 8 WebSocket connection to 'ws://localhost:9528/liveviewhandler/tests/1/developer/ws-proxy' failed: Error during WebSocket handshake: Unexpected response code: 302",
    #     source    => "network",
    #     timestamp => 1707924445186,
    #   },
    # ]

    #   Failed test 'No unexpected js warnings'
    #   at /home/squamata/project/t/lib/OpenQA/Test/FullstackUtils.pm line 123.
    # Looks like you failed 1 test of 9.
[15:26:28] t/33-developer_mode.t .. 20/? 
#   Failed test 'resume test execution and 2nd tab'
#   at t/33-developer_mode.t line 340.
[15:26:28] t/33-developer_mode.t .. 21/? [15:26:28] t/33-developer_mode.t .. 22/? [15:26:28] t/33-developer_mode.t .. 23/? # Looks like you failed 1 test of 23.
                                          [15:26:28] t/33-developer_mode.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/23 subtests 
[15:28:29]

Could it be that I did not use the correct syntax in code? perl -e '$foo = {service_port_delta => $ENV{FOO} // 2}; print $foo->{service_port_delta}' works fine. So what is the problem?

[Martchus]

I also cross-checked the syntax and it really works (although brackets would probably not hurt for readability). The test also seems to generally work (also see log under artifacts) up to that point and t/full-stack.t is fully passing. The ports in the error message also look as they should and it also doesn't complain with "Connection refused". So this might even be an unrelated/sporadic issue.

[Martchus]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased