Remove manual installation of npm when caching assets #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
This was only required for bootstrapping the switch to using npm. Now the container image we use for the CI has been rebuilt and contains the npm package. Related ticket: https://progress.opensuse.org/issues/153427
Martchus
force-pushed
the
assets-via-npm
branch
from
6f805ca
to
fbb618a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5474 +/- ##
==========================================
+ Coverage 98.37% 98.38% +0.01%
==========================================
Files 390 390
Lines 37862 37862
==========================================
+ Hits 37245 37250 +5
+ Misses 617 612 -5 ☔ View full report in Codecov by Sentry. |
kalikiana
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft because we need to merge #5473 first; only then the next paragraph is actually true.
This was only required for bootstrapping the switch to using npm. Now the container image we use for the CI has been rebuilt and contains the npm package.
Related ticket: https://progress.opensuse.org/issues/153427