Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid workers from showing up shortly as broken after registration #5451

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Feb 5, 2024

When working on https://progress.opensuse.org/issues/154927 I noticed that we don't reset the error state of a worker on registration. Normally this is not notable because we do when the worker sends a status update which happens only shortly after the registration. However, it makes still sense to clear the old error status on the registration to avoid workers from possibly being considered broken in the small window between the registration and the first status update. This makes only a difference when the worker did not disconnect gracefully.

When working on https://progress.opensuse.org/issues/154927 I noticed that
we don't reset the error state of a worker on registration. Normally this
is not notable because we do when the worker sends a status update which
happens only shortly after the registration. However, it makes still sense
to clear the old error status on the registration to avoid workers from
possibly being considered broken in the small window between the
registration and the first status update. This makes only a difference when
the worker did not disconnect gracefully.
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d50a81) 98.37% compared to head (28bf0ed) 98.37%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5451   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         389      389           
  Lines       37751    37754    +3     
=======================================
+ Hits        37139    37142    +3     
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit da30293 into os-autoinst:master Feb 7, 2024
41 checks passed
@Martchus Martchus deleted the clear-error-on-registration branch February 7, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants