Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download shepherd.js from cdn.jsdelivr.net #5418

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Download shepherd.js from cdn.jsdelivr.net #5418

merged 2 commits into from
Jan 5, 2024

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Jan 5, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Great PR! Please pay attention to the following items before merging:

Files matching assets/assetpack.def:

This is an automatically generated QA checklist based on modified files.

@perlpunk
Copy link
Contributor Author

perlpunk commented Jan 5, 2024

Now it's failing in OBS: https://build.opensuse.org/package/live_build_log/devel:openQA:GitHub:os-autoinst:openQA:PR-5418/openQA/openSUSE_Tumbleweed/x86_64

[   27s] [2024-01-05 10:01:19.60992] [3379] [warn] [AssetPack] Unable to download https://github.com/shepherd-pro/shepherd/releases/download/v11.2.0/shepherd.js: Can't connect: Temporary failure in name resolution

@perlpunk perlpunk marked this pull request as draft January 5, 2024 10:29
@perlpunk
Copy link
Contributor Author

perlpunk commented Jan 5, 2024 •
edited
Loading

I had problems with running update-cache.sh, I executed the steps manually:

% osc service lr
WARNING: Command 'lr' is obsolete
Already up to date.



bf59e0109f6296a26001991c924db2698af58fa5
% osc service lr tar

WARNING: Command 'lr' is obsolete

# Then I did this instead:
% osc service run tar

but after that _servicedata and openQA.changes were modified with a comment by Oli.
So it might not work correctly in the future.

Since the osc docs don't tell me what lr was supposed to do, I don't have a replacement for it. It's just obsolete :(

@perlpunk perlpunk marked this pull request as ready for review January 5, 2024 11:13
@perlpunk perlpunk changed the title Use shepherdjs url from releases Download shepherd.js from cdn.jsdelivr.net Jan 5, 2024
@baierjan
Copy link
Member

baierjan commented Jan 5, 2024

Since the osc docs don't tell me what lr was supposed to do, I don't have a replacement for it. It's just obsolete :(

According to osc help service:

localrun lr the same as "run" but services with mode "serveronly" are also executed

@perlpunk
Download shepherd.js from cdn.jsdelivr.net
d834a93 
Issue: https://progress.opensuse.org/issues/153145

Also update dist/rpm/update-cache.sh because the lr command apparently
does not do anything anymore:

    % osc service lr tar
    WARNING: Command 'lr' is obsolete
@perlpunk perlpunk mentioned this pull request Jan 5, 2024
Merged
kalikiana
kalikiana reviewed Jan 5, 2024
View reviewed changes
dist/rpm/update-cache.sh
@@ -1,5 +1,8 @@
#! /bin/sh

# Note: this might not work correctly anymore because the 'lr' command
# was obsoleted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documented anywhere? I can't find any mention of it in https://github.com/search?q=repo%3AopenSUSE%2Fobs-docu+localrun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you call osc service lr, it will tell you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it just says WARNING: Command 'lr' is obsolete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @baierjan wrote, osc help service tells me, but I don't know what I can use as a replacement.
I don't know what the update-cache.sh script is supposed to do. When I ran it, more files than expected were changed.

Also, in this case the script cannot be used because it would do cd openQA and generate the tar file from the existing asset urls from the version of openQA in OBS, but I needed the changed version from my local update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ osc service lr
WARNING: Command 'lr' is obsolete, please use 'run' instead.

@perlpunk
Copy link
Contributor Author

perlpunk commented Jan 5, 2024

We can find out about update-cache later. It would be good to merge this to fix our build and not disturb other waiting PRs

@mergify mergify bot merged commit 4d4e5b7 into os-autoinst:master Jan 5, 2024
36 checks passed
@perlpunk perlpunk deleted the shepherdjs-url branch January 5, 2024 15:02
@perlpunk perlpunk mentioned this pull request Jan 5, 2024
Closed
@asdil12
Copy link
Member

asdil12 commented Jan 5, 2024 via email

@Martchus Martchus mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdil12 asdil12 asdil12 approved these changes

@kalikiana kalikiana kalikiana left review comments

@baierjan baierjan baierjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perlpunk @baierjan @asdil12 @kalikiana