Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for Mojo::Base in Documentation for Tests #5404

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

josegomezr
Copy link
Contributor

  • Explain that it includes default best practices for perl (warnings, strict, utf8, etc.).

  • Add a link to Mojo::Base upstream docs.

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-docs

This is an automatically generated QA checklist based on modified files.

docs/WritingTests.asciidoc Outdated Show resolved Hide resolved
docs/WritingTests.asciidoc Outdated Show resolved Hide resolved
- Explain that it includes default best practices for perl (warnings,
  strict, utf8, etc.).

- Add a link to `Mojo::Base` upstream docs.
@josegomezr
Copy link
Contributor Author

Removed the blank line & the <> callout in favor of a note after the code sample.

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify mergify bot merged commit 637df04 into os-autoinst:master Dec 20, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants