-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postgresql recursive feature for getting scheduled product #5398
Conversation
9391446
to
48c10ea
Compare
Typo: efficient The SQL looks correct, but I'm not sure how to tell if it's more or less efficient. |
Regarding efficiency:
And that example is a job in osd which has about 1100 ancestors. |
And we're using that kind of SQL already in |
48c10ea
to
6520e0a
Compare
For longer chains of clones it's more efficient. It also avoids a warning: Deep recursion on subroutine "OpenQA::Schema::Result::Jobs::related_scheduled_product_id" Issue: https://progress.opensuse.org/issues/152569
6520e0a
to
e56b56e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5398 +/- ##
=======================================
Coverage 98.36% 98.37%
=======================================
Files 389 389
Lines 37534 37548 +14
=======================================
+ Hits 36922 36936 +14
Misses 612 612 ☔ View full report in Codecov by Sentry. |
For longer chains of clones it's more efficient. It also avoids a warning:
Issue: https://progress.opensuse.org/issues/152569