Allow passing settings only for specific test when cloning jobs #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
requested changes
Dec 5, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5385 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 389 389
Lines 37493 37494 +1
=======================================
+ Hits 36879 36882 +3
+ Misses 614 612 -2 ☔ View full report in Codecov by Sentry. |
This is especially useful when cloning MM clusters and specific jobs are supposed to run on specific hosts (e.g. to test connectivity between specific hosts). Related ticket: https://progress.opensuse.org/issues/151310
* Avoid printing line number so this doesn't look like a bug in the script itself * Make it clear that this is about a command-line argument and that it is not a valid setting (instead of just saying "does not match")
As discussed on the related PR this has the advantage of being in-line with the "POST jobs"-API. Even though these specifications have a slightly different meaning in these places it still makes sense to use the same syntax so users don't need to remember which syntax to use where.
okurz
approved these changes
Dec 6, 2023
kraih
approved these changes
Dec 7, 2023
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Dec 8, 2023
commit db07886 Merge: f2e8217 7dbb80c Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Thu Dec 7 11:58:55 2023 +0000 Commit: GitHub <[email protected]> CommitDate: Thu Dec 7 11:58:55 2023 +0000 Merge pull request os-autoinst#5385 from Martchus/clone-scope Allow passing settings only for specific test when cloning jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful when cloning MM clusters and specific jobs are supposed to run on specific hosts (e.g. to test connectivity between specific hosts).
Related ticket: https://progress.opensuse.org/issues/151310