Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infopanel: render scenario_description as markdown #5374

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

cfconrad
Copy link
Contributor

I would like to have clickable links in the JOB_DESCRIPTION. With this, I could use the JOB_DESCRIPTION linking to a corresponding trigger source (e.g. a gitlab pipeline).

@cfconrad cfconrad force-pushed the pr_JOB_DESCRIPTION_in_markdown branch from 44ab702 to 17f2445 Compare November 23, 2023 23:02
@cfconrad cfconrad changed the title infopanel: display JOB_DESCRIPTION as markdown WIP: infopanel: display JOB_DESCRIPTION as markdown Nov 24, 2023
@cfconrad cfconrad force-pushed the pr_JOB_DESCRIPTION_in_markdown branch from 17f2445 to acf9c7f Compare November 24, 2023 14:19
@cfconrad cfconrad changed the title WIP: infopanel: display JOB_DESCRIPTION as markdown infopanel: render scenario_description as markdown Nov 24, 2023
@cfconrad
Copy link
Contributor Author

cfconrad commented Nov 24, 2023

Try it with:

openqa-cli api -X POST jobs SCHEDULE="tests/foo/i_do_not_exists" TEST=test_infopanel_markdown JOB_DESCRIPTION='Mark: [Down](http://rocks)'

AFAIK, this change might also affect the view of scenario descriptions used in Testsuites #1094. But I think using Markdown here as well, is a benefit. WDYT?

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now only CI checks need to be fixed

@cfconrad
Copy link
Contributor Author

cfconrad commented Nov 27, 2023

Now only CI checks need to be fixed

Are these failures related to my changes? I didn't connect

Loading repository data...
Reading installed packages...
Package 'alsa-1.2.6.1' not found.
Package 'alsa-ucm-conf-1.2.6.3' not found.
Package 'alsa-utils-1.2.6' not found.
Package 'gdk-pixbuf-loader-rsvg-2.52.6' not found.
Package 'hwdata-0.360' not found.
Package 'libXvnc1-1.10.1' not found.
Package 'libatopology2-1.2.6.1' not found.
Package 'libepoxy0-1.5.9' not found.
Package 'librsvg-2-2-2.52.6' not found.

to the PR (https://app.circleci.com/pipelines/github/os-autoinst/openQA/12567/workflows/ed531370-3d37-4398-8814-57826dac6c12/jobs/117403)

and with https://build.opensuse.org/package/show/devel:openQA:GitHub:os-autoinst:openQA:PR-5374/openQA

 unresolvable: nothing provides openQA-client = 4.6.1700835293.acf9c7f, (got version 4.6.1700951825.872b397-lp155.6187.1) 

I'm not sure where this comes from.

Maybe you can give me a hint how to fix it?

@Martchus
Copy link
Contributor

None of these failures seem related. The cache creation might be fixed by ensuring your commit is based on the latest commit from the master branch. The checks on OBS also look like something we've already been fixed so the same applies here.

I would like to have clickable links in the JOB_DESCRIPTION.
With this, I could use the JOB_DESCRIPTION linking to a corresponding
trigger source (e.g. a gitlab pipeline).
@cfconrad cfconrad force-pushed the pr_JOB_DESCRIPTION_in_markdown branch from acf9c7f to d411e9c Compare November 27, 2023 10:43
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (872b397) 98.36% compared to head (d411e9c) 98.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5374   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         389      389           
  Lines       37441    37445    +4     
=======================================
+ Hits        36827    36831    +4     
  Misses        614      614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 9b4e6c6 into os-autoinst:master Nov 28, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants