Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatted bugref and carryover flag for comments #5357

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Add formatted bugref and carryover flag for comments #5357

merged 7 commits into from
Nov 16, 2023

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Nov 3, 2023 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching assets/stylesheets/**:

  • Consider providing screenshots in a PR comment to show the difference visually

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-htmldoc

This is an automatically generated QA checklist based on modified files.

okurz
okurz requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a good idea to introduce "flags". To be able to answer that I suggest you start with updating the documentation to explain flags. Maybe that can show us if this too confusing or helpful.

templates/webapi/comments/add_comment_form_groups.html.ep Outdated Show resolved Hide resolved
perlpunk
perlpunk reviewed Nov 3, 2023
View reviewed changes
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
Martchus
Martchus reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a generic flagging mechanism makes sense. Can you update the documentation?

I suppose https://progress.opensuse.org/issues/136244 should be mentioned in the commit message.

lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
templates/webapi/comments/add_comment_form_groups.html.ep Outdated Show resolved Hide resolved
@asdil12 asdil12 force-pushed the carryover branch 3 times, most recently from b5f46a5 to 985b922 Compare November 3, 2023 13:45
Martchus
Martchus previously requested changes Nov 3, 2023
View reviewed changes
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
@asdil12 asdil12 force-pushed the carryover branch 3 times, most recently from efc0b05 to fca75d5 Compare November 3, 2023 14:32
kalikiana
kalikiana reviewed Nov 3, 2023
View reviewed changes
lib/OpenQA/Schema/Result/Comments.pm Outdated Show resolved Hide resolved
lib/OpenQA/Utils.pm Outdated Show resolved Hide resolved
lib/OpenQA/Markdown.pm Outdated Show resolved Hide resolved
@Martchus Martchus dismissed their stale review November 13, 2023 11:07

Looks like moving the code to the schema would mean refactoring lots of test code so I guess it is good enough.

@asdil12 asdil12 force-pushed the carryover branch 2 times, most recently from d27fca5 to 905f974 Compare November 13, 2023 16:46
Martchus
Martchus reviewed Nov 13, 2023
View reviewed changes
t/ui/14-dashboard.t Outdated Show resolved Hide resolved
okurz
okurz requested changes Nov 14, 2023
View reviewed changes
lib/OpenQA/Utils.pm Outdated Show resolved Hide resolved
assets/stylesheets/comments.scss Outdated Show resolved Hide resolved
@asdil12 asdil12 force-pushed the carryover branch 2 times, most recently from 8b3a4f4 to a8dfe31 Compare November 14, 2023 14:06
@asdil12 asdil12 marked this pull request as ready for review November 14, 2023 14:48
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94ee812) 98.32% compared to head (7015130) 98.32%.
Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5357   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         389      389           
  Lines       37320    37355   +35     
=======================================
+ Hits        36694    36729   +35     
  Misses        626      626

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Martchus
Martchus requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. I'd only avoid repetition in the CSS code.

assets/stylesheets/comments.scss Show resolved Hide resolved
assets/stylesheets/comments.scss Show resolved Hide resolved
Martchus
Martchus requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the test changes are good. I only have a few remarks and also see the comments from my previous review.

t/17-labels_carry_over.t Outdated Show resolved Hide resolved
t/17-labels_carry_over.t Outdated Show resolved Hide resolved
@perlpunk
Copy link
Contributor

Was my comment #5357 (comment) considered?

@asdil12 asdil12 force-pushed the carryover branch 2 times, most recently from fb7d6bd to fd018bc Compare November 15, 2023 15:38
@okurz
Copy link
Member

okurz commented Nov 16, 2023

Was my comment #5357 (comment) considered?

done that now with #5357 (comment)

okurz
okurz requested changes Nov 16, 2023
View reviewed changes
t/16-markdown.t Outdated Show resolved Hide resolved
t/16-markdown.t Outdated Show resolved Hide resolved
templates/webapi/comments/add_comment_form_groups.html.ep Show resolved Hide resolved
@asdil12 asdil12 force-pushed the carryover branch 2 times, most recently from 6267a35 to c0373be Compare November 16, 2023 10:16
okurz
okurz requested changes Nov 16, 2023
View reviewed changes
docs/UsersGuide.asciidoc Outdated Show resolved Hide resolved
@asdil12 asdil12 force-pushed the carryover branch 2 times, most recently from 29a3102 to 883aee4 Compare November 16, 2023 13:03
@mergify mergify bot merged commit 90cbb53 into os-autoinst:master Nov 16, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlpunk perlpunk perlpunk left review comments

@kalikiana kalikiana kalikiana left review comments

@okurz okurz okurz approved these changes

@Martchus Martchus Martchus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asdil12 @perlpunk @okurz @kalikiana @Martchus