-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document run_args
limitation on Python Modules
#5340
Document run_args
limitation on Python Modules
#5340
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also remove the .
at the end of the commit message.
c5de908
to
efb121b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. Please observe the comment from Martchus about the git commit message subject line
efb121b
to
9375285
Compare
run_args
limitation on Python Modules.run_args
limitation on Python Modules
Arguments sent from Perl to Python can't be used (due to blessed references not properly translated to Python into usable objects) Python test modules do not support any other argument but `self`. A note of caution is added to warn against using any argument in the `run` function and updated examples This limitation is enforced now in os-autoinst and now documented in the docs Co-authored-by: Martchus <[email protected]>
9375285
to
3512c2c
Compare
commit d08787a Merge: 83ab402 3512c2c Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Mon Oct 23 19:31:03 2023 +0000 Commit: GitHub <[email protected]> CommitDate: Mon Oct 23 19:31:03 2023 +0000 Merge pull request os-autoinst#5340 from josegomezr/docs_add_ctx_on_py_run_args Document `run_args` limitation on Python Modules
Arguments sent from Perl to Python can't be used (due to blessed references not properly translated to Python into usable objects).
A note of caution is added to warn against using any argument in the
run
function and updated examples.