Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: Require Mojo OAuth2 plugin #5268

Merged

Conversation

davidmhewitt
Copy link
Contributor

@davidmhewitt davidmhewitt commented Jul 29, 2023

Fixes #5266

Means that OAuth2 authentication is supported by default in the containers built from these RPMs.

This is the result of moving the plugin from the test section of dependencies.yaml into the main section and running make update-deps.

@okurz
Copy link
Member

okurz commented Jul 29, 2023

What you put into the description of the pull request could also be in the commit message details. I don't know how you created your pull request but your git commit messages has only the subject line while the pull request description has more details. Please keep in mind that the github pull request description is only visible on github, the commit can be considered permanent information storage.

I can recommend the tool hub (zypper in rubygem-hub) for easier PR creation. Also, I myself use a script git-pr-last to create a PR with proper description for these simple one-commit PRs:

$ cat $(which git-pr-last )
#!/bin/sh -e
target="${target:-"$USER"}"
git push $target && git show --no-patch --format=%B | hub pull-request -F -

You might want to use the more up-to-date tool https://github.com/cli/cli

Fixes os-autoinst#5266

Means that OAuth2 authentication is supported by default in the
containers built from these RPMs.

This is the result of moving the plugin from the test section of
dependencies.yaml into the main section and running make update-deps.
@davidmhewitt davidmhewitt force-pushed the mojo-oauth2-plugin-requirement branch from afbbc06 to a27c664 Compare July 29, 2023 17:25
@davidmhewitt
Copy link
Contributor Author

@okurz Apologies! I've force pushed a new commit with a more detailed description.

@mergify mergify bot merged commit e47aebd into os-autoinst:master Jul 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Install Oauth2 Plugin By Default in Containers
4 participants