Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid errors in the logs when invalid job IDs are passed #5239

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Martchus
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #5239 (9c29c6d) into master (4aa69aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5239   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         389      389           
  Lines       37133    37139    +6     
=======================================
+ Hits        36506    36512    +6     
  Misses        627      627           
Impacted Files Coverage Δ
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 96.74% <100.00%> (+0.03%) ⬆️
t/api/04-jobs.t 100.00% <100.00%> (ø)

@mergify mergify bot merged commit d700b62 into os-autoinst:master Jul 11, 2023
13 checks passed
@Martchus Martchus deleted the id-validation branch July 11, 2023 09:51
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change makes sense, the actual error in the log cited in the ticket seems to be rather coming from this request:

GET /api/v1/jobs?build=20210707&groupid=https%3A%2F%2Fwww.google.com%2Fmi%2F

It's complaining about the group_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants