-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert script/configure-web-proxy from POSIX sh to bash #5235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep it POSIX sh? Or was it inconsistent in before?
Because almost all systems have bash installed (even if it is not the shell used by the user) so it makes no sense to limit ourselves to inferior shell syntax. |
Ok, that's a good reason why the change can be done without significant impact but is not a reason why the change would provide a benefit |
I guess we should decide: Make all scripts rely on bash features like |
|
Missing codecov feedback @Mergifyio rebase |
I think mergify never rebased but it seems the codecov report nevertheless eventually arrived :D |
No description provided.