Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert script/configure-web-proxy from POSIX sh to bash #5235

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jul 6, 2023

No description provided.

script/configure-web-proxy Outdated Show resolved Hide resolved
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep it POSIX sh? Or was it inconsistent in before?

@Martchus
Copy link
Contributor

Martchus commented Jul 6, 2023

Because almost all systems have bash installed (even if it is not the shell used by the user) so it makes no sense to limit ourselves to inferior shell syntax.

@okurz
Copy link
Member

okurz commented Jul 6, 2023

Because almost all systems have bash installed (even if it is not the shell used by the user) so it makes no sense to limit ourselves to inferior shell syntax.

Ok, that's a good reason why the change can be done without significant impact but is not a reason why the change would provide a benefit

@asdil12
Copy link
Member Author

asdil12 commented Jul 6, 2023

Because almost all systems have bash installed (even if it is not the shell used by the user) so it makes no sense to limit ourselves to inferior shell syntax.

Ok, that's a good reason why the change can be done without significant impact but is not a reason why the change would provide a benefit

I guess we should decide: Make all scripts rely on bash features like == or [[ or be posix sh compliant.
I see no value in the current chaotic situation where we try to enforce [[ in one file but hesitate to do the same in other files.

@asdil12 asdil12 marked this pull request as ready for review July 7, 2023 11:42
@Martchus
Copy link
Contributor

Martchus commented Jul 7, 2023

s/Remvoe/Remove/ in the commit message

@okurz
Copy link
Member

okurz commented Jul 7, 2023

Missing codecov feedback

@Mergifyio rebase

@mergify mergify bot merged commit a3a5f95 into os-autoinst:master Jul 7, 2023
13 checks passed
@okurz
Copy link
Member

okurz commented Jul 8, 2023

I think mergify never rebased but it seems the codecov report nevertheless eventually arrived :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants