Skip to content

Commit

Permalink
style: Fix custom footer overflow
Browse files Browse the repository at this point in the history
On an openQA page using a custom links_footer_left and/or
links_footer_right, e.g.
https://openqa.suse.de/tests/overview?distri=sle&build=20240318-1&result=incomplete
the version string in the footer is cropped despite enough white space
being available. The full version string is readable by scrolling down
but the scroll bar should not be necessary. So no cropping and no scroll
bar should appear if there is enough blank space in both the case of
with or without a custom footer_link content used or not.

This problem was originally introduced with 58747a5 setting a fixed
height which offsets the version string from the bottom to make it more
readable but does not account for the optional custom_footer inclusion.

This commit fixes this by using a bottom padding instead of prescribing
the overall height of the complete footer box.

Related progress issue: https://progress.opensuse.org/issues/157576
  • Loading branch information
okurz committed Mar 25, 2024
1 parent fa170aa commit b7e638e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions assets/stylesheets/overall.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ body {
position: absolute;
bottom: 0;
width: 100%;
// set the fixed height of the footer here
height: 30px;
padding-bottom: 10px;
background-color: #f5f5f5;
}
.darkmode {
Expand Down

0 comments on commit b7e638e

Please sign in to comment.