Apply suggestions from code review

Co-authored-by: Martchus <[email protected]>
Co-authored-by: Tina Müller (tinita) <[email protected]>

lib/OpenQA/WebAPI/Plugin/ObsRsync.pm

@@ -535,9 +535,9 @@ sub _for_every_batch {
 
 # Based on https://www.suse.com/c/multi-factor-authentication-on-suses-build-service/
 sub _bs_ssh_sign ($key, $realm, $value) {
-    die "SSH Key File not found at $key" unless (-e $key || -z $key);
+    die "SSH key file not found at $key" unless -s $key;
     # This needs to be a bit portable for CI testing
-    my $tmp = Mojo::File::tempfile->spew($value);
+    my $tmp = Mojo::File::tempfile('obs-rsync-ssh-keyfile-XXXXX')->spew($value);
     my @lines = split "\n", qx/ssh-keygen -Y sign -f "$key" -q -n "$realm" < $tmp/;
     shift @lines;
     pop @lines;