Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life improvements #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Quality of life improvements #30

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2021

Hello everyone, I took the freedom of renewing the project folder structure to something more organized. Also added a CMake script for building.

The CMake script can build the static library, shared library and test executable all at once. Targeting both x86 and x86_64 through a cmake flag.

Actually the switches for multilib compiling are only supported by GCC and Clang I guess (-m32 for x86 and -m64 for x86_64). I haven't tested with MSVC.

I removed one unused include at src/test.c:10.

@Leont
Copy link

Leont commented Nov 23, 2021

Generally speaking, I would recommend asking the maintainer before doing something as invasive like this.

This contains two different changes. One is reorganizing the code: moving the header files to a separate directory and changing the include paths. The other is adding a CMake file. The latter isn't particularly disruptive, the former on the other hand will disrupt other users. I don't really understand why that would be necessary in the first place.

Or why you called this Quality of life improvements instead of Add CMake support. Other people may not share your preferences of build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant