drop-down menu closes on clicking hamburger icon #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
origranot
reviewed
Oct 13, 2023
apps/frontend/src/components/navbar/burger-button/burger-button.tsx
Outdated
Show resolved
Hide resolved
origranot
reviewed
Oct 13, 2023
origranot
reviewed
Oct 13, 2023
origranot
requested changes
Oct 13, 2023
There was a problem hiding this comment.
@mrswastik-robot Great job!
I left some comments on this PR, please fix those issues 💯
Thanks @origranot for responding. I would surely work on requested changes ASAP. |
…/reduced.to into hiding-hamburger
|
@origranot I have made the changes as requested , can you review it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488
I am using ' useSignal()' to store the state and change it 'false' whenever the hamburger icon is clicked in order to hide the hamburger menu.
Do suggest me if any improvements or changes are required.