Fixes : #480 Added Dark mode logo in Hero #486
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@siddharth9300 Can't we do all of it with the fill property, what do you think? |
fill property of svg
@origranot Yes we can ,please check the latest changes. I have made changes and done it with the fill property. |
I checked it, well done! |
|
@origranot Instead of using fill property I have used filter property. I have committed the changes. We don't need to duplicate svg code we can use img tag. |
|
@siddharth9300 Hey, can you please run the formatter to fix the prettier issues? |
|
@origranot Done 👍 |
There was a problem hiding this comment.
@siddharth9300 Great job!
I added few comments, what do you think?
apps/frontend/src/routes/index.tsx
Outdated
| const logoStyle = { | ||
| filter: globalStore.theme === 'light' ? 'invert(0)' : 'invert(1)', | ||
| }; |
There was a problem hiding this comment.
I think this logic should move to the tag.
There was a problem hiding this comment.
@siddharth9300 Just move the condition to the <img> tag below.
There was a problem hiding this comment.
@origranot done👍
Fixes : #480 Added Dark mode logo in hero section by creating different logo for dark mode and light mode.
Dark Mode :
Light mode :
