Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): check pedantic lints #853

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

nejcgalof
Copy link
Contributor

@nejcgalof nejcgalof commented Sep 15, 2024

Description

Add pedantic lints checking to the CI and do not fail the CI if warnings exist.

Motivation and Context

It is good to have some reports about pedantic errors at the merging level, especially in pull requests. Now, users can see the quality of their code on a pedantic linter level.

We are currently resolving many pedantic errors in the existing code in the other MR.

How Has This Been Tested?

I tested the command manually in the terminal.
I tested the CI in that pull request. If the build passes and we have an extra step in the Lints job with pedantic warnings, that means we have configured the CI correctly.
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other - CI

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.94%. Comparing base (fe37d14) to head (9eba16d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   39.94%   39.94%           
=======================================
  Files          20       20           
  Lines        1660     1660           
=======================================
  Hits          663      663           
  Misses        997      997           
Flag Coverage Δ
unit-tests 39.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Sep 15, 2024

Oops, there seems to be a lot of lints :D I guess it's fine to ignore some of them for now.

@nejcgalof
Copy link
Contributor Author

Yes :) For that reason, I split the nice checks into multiple MRs instead of solving them in one MR. I will ignore some of them. I still have around 15 checks left on my TODO list. Is it okay with you if I continue with them using the workflow I had before (each check is in a separate MR)?

When I finish with them, I can ping you, and we can decide what to do with the rest of them. We can also ignore the rest of the checks in the pedantic CI check.

@orhun
Copy link
Owner

orhun commented Sep 15, 2024

Yup, sounds good, as long as we don't exaggerate things a lot :) I don't like all the pedantic lints tbh, the ones you sent were reasonable so far.

@orhun orhun merged commit c77420c into orhun:main Sep 21, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants