Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use stable rustfmt #834

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MarcoIeni
Copy link
Contributor

@MarcoIeni MarcoIeni commented Aug 31, 2024

Description

close #618

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MarcoIeni MarcoIeni marked this pull request as ready for review August 31, 2024 08:02
@MarcoIeni MarcoIeni requested a review from orhun as a code owner August 31, 2024 08:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 64.10256% with 28 lines in your changes missing coverage. Please review.

Project coverage is 40.15%. Comparing base (f5c39a2) to head (77b6b6b).

Files with missing lines Patch % Lines
git-cliff-core/src/changelog.rs 53.85% 12 Missing ⚠️
git-cliff/src/lib.rs 0.00% 8 Missing ⚠️
git-cliff-core/src/repo.rs 72.00% 7 Missing ⚠️
git-cliff-core/src/remote/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   40.10%   40.15%   +0.05%     
==========================================
  Files          21       21              
  Lines        1671     1684      +13     
==========================================
+ Hits          670      676       +6     
- Misses       1001     1008       +7     
Flag Coverage Δ
unit-tests 40.15% <64.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Aug 31, 2024

We should probably cut a new point release just for these changes 💀

Do you know if there is a way of keeping the git blame while changing the formatting? I'm guessing it shouldn't be possible but it would be super nice if we can keep the historic footprint on the files somehow.

@MarcoIeni
Copy link
Contributor Author

@orhun
Copy link
Owner

orhun commented Sep 1, 2024

Wow perfect, please do it 👍🏼

@MarcoIeni
Copy link
Contributor Author

Actually, I think we need to do this in another PR, after merging this so that we know the commit to ignore 👍

@orhun
Copy link
Owner

orhun commented Sep 21, 2024

Can you push this again? There seems to be some conflicts.

Actually, I think we need to do this in another PR, after merging this so that we know the commit to ignore 👍

I won't do a squash merge for this PR so it should be safe to use the commit hash :)

@MarcoIeni MarcoIeni force-pushed the fmt-stable branch 2 times, most recently from 5e05999 to d8e22b5 Compare October 2, 2024 19:54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all unstable options. Plus edition is read from Cargo.toml

@MarcoIeni
Copy link
Contributor Author

MarcoIeni commented Oct 2, 2024

Ready for another look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stable rust for cargo-fmt
3 participants