wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>
orchestral · Jul 21, 2023 · 468fcb9 · 468fcb9
1 parent eb854df
commit 468fcb9
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -19,6 +19,14 @@
     "autoload": {
         "psr-4": {
             "Orchestra\\DuskUpdater\\": "src/"
+        },
+        "files": [
+            "src/helpers.php"
+        ]
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "Orchestra\\DuskUpdater\\Tests\\": "tests/"
         }
     },
     "require": {

diff --git a/src/UpdateCommand.php b/src/UpdateCommand.php
@@ -134,7 +134,7 @@ protected function rename(string $binary, string $os): void
             throw new RuntimeException("Unable to rename {$binary} without --install-dir");
         }
 
-        $newName = array_reverse(explode(DIRECTORY_SEPARATOR, str_replace('chromedriver', 'chromedriver-'.$os, $binary), 2))[0];
+        $newName = chromedriver_binary_filename($binary, $os);
 
         rename($this->directory.$binary, $this->directory.$newName);
 

diff --git a/src/helpers.php b/src/helpers.php
@@ -0,0 +1,10 @@
+<?php 
+
+namespace Orchestra\DuskUpdater;
+
+function chromedriver_binary_filename(string $binary, string $os): string
+{
+    return strpos($binary, DIRECTORY_SEPARATOR) > 0
+        ? array_reverse(explode(DIRECTORY_SEPARATOR, str_replace('chromedriver', 'chromedriver-'.$os, $binary), 2))[0]
+        : str_replace('chromedriver', 'chromedriver-'.$os, $binary);
+}