fix lint

Signed-off-by: Houssem Ben Mabrouk <[email protected]>
orange-cloudfoundry · Apr 22, 2024 · 8e0a619 · 8e0a619
1 parent 4137a9c
commit 8e0a619
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/connector/oidc/oidc.go b/connector/oidc/oidc.go
@@ -381,9 +381,9 @@ func (c *oidcConnector) getTokenViaClientCredentials(r *http.Request) (token *oa
 		clientSecret = q.Get("custom_client_secret")
 	}
 
-	// Check if parsed credentials are not empty
+	// Check if oauth2 credentials are not empty
 	if len(clientID) == 0 || len(clientSecret) == 0 {
-		return nil, fmt.Errorf("oidc: unable to parse clientID or clientSecret")
+		return nil, fmt.Errorf("oidc: unable to get clientID or clientSecret")
 	}
 
 	// Construct data to be sent to the external IdP

diff --git a/connector/oidc/oidc_test.go b/connector/oidc/oidc_test.go
@@ -424,7 +424,6 @@ func TestHandleCallback(t *testing.T) {
 			clientCredentials: false,
 		},
 		{
-
 			name:               "withCustomCredentials",
 			userIDKey:          "", // not configured
 			userNameKey:        "", // not configured
@@ -482,7 +481,7 @@ func TestHandleCallback(t *testing.T) {
 			customClientSecret:   "", // not configured in the request
 			scopes:               []string{"openid"},
 			token:                nil,
-			expectedHandlerError: fmt.Errorf("oidc: unable to parse clientID or clientSecret"),
+			expectedHandlerError: fmt.Errorf("oidc: unable to get clientID or clientSecret"),
 			clientCredentials:    true,
 		},
 		{
@@ -499,7 +498,7 @@ func TestHandleCallback(t *testing.T) {
 			customClientSecret:   "", // not configured in the request
 			scopes:               []string{"openid"},
 			token:                nil,
-			expectedHandlerError: fmt.Errorf("oidc: unable to parse clientID or clientSecret"),
+			expectedHandlerError: fmt.Errorf("oidc: unable to get clientID or clientSecret"),
 			clientCredentials:    true,
 		},
 	}