-
Notifications
You must be signed in to change notification settings - Fork 101
Implement eq and as_str in LinuxCapabilityType #37
base: master
Are you sure you want to change the base?
Conversation
Is anything blocking this right now? |
I don't believe @josselinchevalay has signed the CLA so I can't merge. That said, I don't follow the updated logic. If difference is working properly, the if statement on the second line should always be false. |
I did not look into the code itself, just wondering why this is dangling :) |
hi all, yep second if statement seems return false always, i didn't why ? for CLA how to signed ? Regards |
Instructions and a link to the OCA info can be found on the contributing page: https://github.com/oracle/railcar/blob/master/CONTRIBUTING.md |
but yes i still don't think this new logic is correct. |
@josselinchevalay it's been a while, any news? |
@drahnr nop i need to sign CLA. do you have same issue ? |
I already signed the CLA :) |
ok for me that solved my issue with caps errors |
Could you add print statement and show the two prints of the old and new logic. I am not quite sure what should differ between both of them. |
i created an issue #36
for solved that i propose this pull request let me know your advice.
Regards