Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-51571] Add support for methods that need frame pointer. #8990

Merged
merged 1 commit into from
May 29, 2024

Conversation

graalvmbot
Copy link
Collaborator

This PR adds support for establishing a frame pointer in methods that perform non-standard stack pointer modifications (e.g., outside of the prologue and epilogue) in order to properly support stack unwinding.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 29, 2024
@adinn
Copy link
Collaborator

adinn commented May 29, 2024

@pejovica Does this change have any implications for validity of debug info?

@graalvmbot graalvmbot closed this May 29, 2024
@graalvmbot graalvmbot deleted the ap/GR-51571-fp-support branch May 29, 2024 16:04
@graalvmbot graalvmbot merged commit 1db2d48 into master May 29, 2024
13 checks passed
@pejovica
Copy link
Member

@adinn Not on its own, but I'll be introducing new SubstrateMarkIds in a follow-up PR to make use of this change when generating Windows unwind info, and it should be possible to make use of them to improve accuracy of debug info too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants