-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52025] Use update center for NetBeans 14 in IGV #8290
[GR-52025] Use update center for NetBeans 14 in IGV #8290
Conversation
With this fix, I can install upcoming version of Enso4Igv plugin into IGV, |
Yes this looks good. I'll integrate it. |
Thank you, Tom. Will you also update the binary that is used when
please? I could change the suite.py URL, but I certainly cannot upload the new bits to lafo... |
Yes I will also update the binary. I was actually going to update to netbeans 20 at the same time but I'm hitting confusing problems with the dependencies and the unit tests. In particular the tests seem to have trouble loading net.java.html
even though Settings has a clear dependence on it
Note test locally I've updated the specification version from 1.3.0 to 1.81 since some files specified 1.3.0 and others 1.8.1. Anyway I have no clue why it can't load the module. The actual IGV binary works fine but getting the unit tests to work has always seemed fairly fragile. Any suggestions? |
I put the initial changes from the update to 20 in #8359 if you want to have a look. In includes an equivalent change to the update center for 20 as well. |
Integrating my change first, would be "safer".
The module should be at |
I can see it's definitely there and the full IGV works just fine but it's not being loaded in the context of the unit tests. And there's no output explaining why. Presumably there's some step that collects the required modules for running the test and it's being left out but I can't see why. I've tried sprinkling that around in the involved modules but without luck. Is there some trick to getting the dependencies right for the unit tests? It seems like a very manual process. |
Tom, I am sorry to hear you have problems to upgrade to NetBeans 20. However upgrading to NetBeans 20 doesn't have anything to do with my fix proposed in this PR. Can you help me integrate fix in this PR first and only then seek help of Oracle NetBeans experts like @sdedic, @dbalek, etc. to resolve the upgrading? I'd prefer to move forward by smaller steps rather than getting stuck while trying to make a huge leap. It is important that IGV keeps up with latest NetBeans releases, but all I need right now is just this PR small bugfix. Thank you for helping and unblocking an outsider like me. |
Sorry I was out on vacation last week, but I've come to the same conclusion that I should just update against the current release for now and work out my netbeans issues separately. It is disappointing that the IDE can't tell me what wrong with the test dependencies. Whatever the issues is, it appeared with Netbeans 18. I'll adjust my PR to push your fix along with a few minor fixes. |
Good!
Yes, this is not really widely used functionality. I assume most of the NetBeans Platform application based projects have already migrated to Maven and regressions in this Ant based support just pass thru the release process unnoticed. As a NetBeans founder I feel I should be glad to help you, but refreshing/rebooting memory isn't easy and nobody is going to reward me for such mental reboot. OracleLabs employs enough experienced ex-NetBeans engineers. Ask them for help. |
Looks like IGV has been updated to use NetBeans-14, however the system is still configured to use update centers from NetBeans 12.5 - that's unfortunate as the latest versions of plugins aren't available. This PR aligns the IGV's base NetBeans version with its update centers.
CCing @tkrodriguez, @sdedic, @dbalek, @Ondrej-Douda