[GR-51017] Use JDK 17 for building Quarkus #7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
reviewed
Dec 19, 2023
.github/workflows/quarkus.yml
Outdated
| # Use Java 17 to build Quarkus as that's the lowest supported JDK version currently | ||
| - uses: graalvm/setup-graalvm@v1 | ||
| with: | ||
| version: 'latest' |
There was a problem hiding this comment.
version is deprecated. As much as I like using setup-graalvm, maybe it's better to use setup-java instead because here, we only care about compiling with javac?
There was a problem hiding this comment.
Mostly yes. We decided to use GraalVM just as a very basic test that Quarkus compiles with it.
There was a problem hiding this comment.
Updated to using Temurin builds of JDK 17
There was a problem hiding this comment.
Thanks! Could we change this to use Oracle JDK? I can make the change unless you'd like to do it.
There was a problem hiding this comment.
Sure, please go ahead.
Quarkus no longer supports JDK 11. Furthermore, no actual tests are being run with GraalVM in JVM-mode so using it instead of Temurin builds doesn't seem to have any benefits.
zakkak
force-pushed
the
2023-12-11-fix-quarkus-ci
branch
from
3d087da
to
68aa1b5
Compare
fniephaus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarkus no longer supports JDK 11
See https://github.com/oracle/graal/actions/runs/7162366442/job/19499236553#step:12:2328