collect on allocation crossing max

oracle · Oct 8, 2024 · a969e13 · a969e13
1 parent a8efbf7
commit a969e13
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/...le.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/AbstractCollectionPolicy.java b/...le.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/AbstractCollectionPolicy.java
@@ -87,11 +87,11 @@ protected AbstractCollectionPolicy(int initialNewRatio, int initialTenuringThres
     }
 
     @Override
-    public boolean shouldCollectOnAllocation() {
+    public boolean shouldCollectOnAllocation(UnsignedWord allocationSize) {
         if (sizes == null) {
             return false; // updateSizeParameters() has never been called
         }
-        UnsignedWord edenUsed = HeapImpl.getAccounting().getEdenUsedBytes();
+        UnsignedWord edenUsed = HeapImpl.getAccounting().getEdenUsedBytes().add(allocationSize);
         return edenUsed.aboveOrEqual(edenSize);
     }
 

diff --git a/...cle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/BasicCollectionPolicies.java b/...cle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/BasicCollectionPolicies.java
@@ -57,8 +57,8 @@ protected static UnsignedWord m(long bytes) {
         }
 
         @Override
-        public boolean shouldCollectOnAllocation() {
-            UnsignedWord youngUsed = HeapImpl.getAccounting().getYoungUsedBytes();
+        public boolean shouldCollectOnAllocation(UnsignedWord allocationSize) {
+            UnsignedWord youngUsed = HeapImpl.getAccounting().getYoungUsedBytes().add(allocationSize);
             return youngUsed.aboveOrEqual(getMaximumYoungGenerationSize());
         }
 
@@ -243,7 +243,7 @@ public String getName() {
     public static final class NeverCollect extends BasicPolicy {
 
         @Override
-        public boolean shouldCollectOnAllocation() {
+        public boolean shouldCollectOnAllocation(UnsignedWord allocationSize) {
             throw VMError.shouldNotReachHere("Caller is supposed to be aware of never-collect policy");
         }
 

diff --git a/...com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/CollectionPolicy.java b/...com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/CollectionPolicy.java
@@ -119,7 +119,7 @@ static boolean shouldCollectYoungGenSeparately(boolean defaultValue) {
      * {@code true} will initiate a safepoint during which {@link #shouldCollectCompletely} will be
      * called followed by the collection.
      */
-    boolean shouldCollectOnAllocation();
+    boolean shouldCollectOnAllocation(UnsignedWord allocationSize);
 
     /**
      * Called when an application provides a hint to the GC that it might be a good time to do a

diff --git a/...atevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/GCImpl.java b/...atevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/GCImpl.java
@@ -159,7 +159,7 @@ public void maybeCollectOnAllocation(UnsignedWord allocationSize) {
         if (hasNeverCollectPolicy()) {
             UnsignedWord edenUsed = HeapImpl.getAccounting().getEdenUsedBytes();
             outOfMemory = edenUsed.aboveThan(GCImpl.getPolicy().getMaximumHeapSize());
-        } else if (getPolicy().shouldCollectOnAllocation()) {
+        } else if (getPolicy().shouldCollectOnAllocation(allocationSize)) {
             AllocationRequiringGCEvent.emit(getCollectionEpoch(), allocationSize);
             outOfMemory = collectWithoutAllocating(GenScavengeGCCause.OnAllocation, false);
         }