Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network cluster as Virtual Chassis #13

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

BeArchiTek
Copy link
Contributor

Works for Juniper Virtual-Chassis and Cisco nexus VPC
Need improvement for MLAG I think.

@BeArchiTek BeArchiTek self-assigned this Oct 3, 2024
@BeArchiTek BeArchiTek added the type: enhancement New feature or request label Oct 3, 2024
@BeArchiTek BeArchiTek marked this pull request as ready for review October 3, 2024 13:48
@BeArchiTek
Copy link
Contributor Author

I may need to rework it to have the other standard Device field like Interface and hostname on the Virtual Chassis directly.

label: Member
description: "A regular member of the chassis. (i.e line-card for Juniper)"
relationships:
- name: device
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering here if instead of having a relationship (meaning that we need to create the device then create "chassis member" object to tie everything together) it wouldn't be easier to have this chassis member inheriting from the device generic (or maybe physical device generic as well).

Thus from a user point of view you would just have to create on device of subtype "chassis member"

cc @BeArchiTek

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could have device and have to add it to a chassis. A "chassis member" is a normal device, so for me no we should not have it inheriting from generic device.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but in that case you would have to create: device -> chassis member -> virtual-chassis

extensions/network_cluster/README.md Outdated Show resolved Hide resolved
label: Member
description: "A regular member of the chassis. (i.e line-card for Juniper)"
relationships:
- name: device
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but in that case you would have to create: device -> chassis member -> virtual-chassis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants