Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformly check nil responses in backend tests #534

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Uniformly check nil responses in backend tests #534

merged 5 commits into from
Jul 14, 2023

Conversation

artek-koltun
Copy link
Contributor

see #533

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #534 (7df8f7e) into main (339f06d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   70.67%   70.75%   +0.07%     
==========================================
  Files          21       21              
  Lines        3414     3423       +9     
==========================================
+ Hits         2413     2422       +9     
  Misses        895      895              
  Partials      106      106
Impacted Files Coverage Δ
pkg/server/utils.go 10.57% <100.00%> (+8.47%) ⬆️

@artek-koltun artek-koltun marked this pull request as ready for review July 14, 2023 08:05
@artek-koltun artek-koltun requested a review from a team as a code owner July 14, 2023 08:05
glimchb
glimchb approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great alignment

@glimchb glimchb merged commit 67c3cb5 into opiproject:main Jul 14, 2023
17 checks passed
@artek-koltun artek-koltun mentioned this pull request Jul 17, 2023
Closed
@artek-koltun artek-koltun deleted the tests-uniformly-check-nil-responses branch November 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb