feat(evpn unit test): adding evpn mock unit test

[atulpatel261194]

[glimchb]

• please add line to

  godpu/Makefile

  Line 29 in c02fd8d

  mockery --config=mocks/.mockery.yaml --name=InvClient --dir=inventory

  to generate new evpn mockery
• and network folder to

  godpu/Makefile

  Line 23 in c02fd8d

  ginkgo grpc inventory

  to run tests

[codecov]

Codecov Report

Merging #276 (06847d3) into main (c02fd8d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #276   +/-   ##
=====================================
  Coverage   8.07%   8.07%           
=====================================
  Files         13      13           
  Lines       2006    2006           
=====================================
  Hits         162     162           
  Misses      1826    1826           
  Partials      18      18           

[glimchb]

Lgtm

[artek-koltun]

@atulpatel261194 A bit late, but why do you test the generated mock here in these tests? Testing of mocks adds little value to our test suite.
I think we should test the implementation(evpnClientImpl) calls a corresponding method in pb.BridgePortServiceClient instead...

[atulpatel261194]

@artek-koltun testing the generated mocks protects the changes in .proto files.
i believe we can't test the real api's which create, delete and update different port, bridge, svi and vrf. if there is any way i can test these api's directly Please let me know.

[artek-koltun]

There is actually a way. You can use dependency injection to replace the real connection components. The test would look like

func TestCreateBridgePortSuccess(t *testing.T) {
	wantRequest := &_go.CreateBridgePortRequest{
		BridgePortId: "bp1",
		BridgePort: &pb.BridgePort{
			Spec: &pb.BridgePortSpec{
				MacAddress:     []byte("00:11:22:aa:bb:cc"), // Is it valid approach? Should we use net.ParseMac()?
				Ptype:          _go.BridgePortType_ACCESS,
				LogicalBridges: []string{"lb1", "lb2"},
			},
		},
	}
	wantResponse := wantRequest.BridgePort

	mockClient := mocks.NewBridgePortServiceClient(t)
	mockClient.EXPECT().CreateBridgePort(mock.Anything, wantRequest).
		Return(proto.Clone(wantResponse).(*pb.BridgePort), nil)

	connClosed := false
	mockConn := mocks.NewConnector(t)
	mockConn.EXPECT().NewConn().Return(
		&grpc.ClientConn{},
		func() { connClosed = true },
		nil,
	)

	c, _ := network.NewBridgePortWithArgs(
		mockConn,
		func(grpc.ClientConnInterface) pb.BridgePortServiceClient {
			return mockClient
		},
	)
	
	response, err := c.CreateBridgePort(
		context.Background(),
		"bp1", "00:11:22:aa:bb:cc", "access", []string{"lb1", "lb2"},
	)

	assert.NoError(t, err)
	assert.True(t, proto.Equal(response, wantResponse))
	assert.Equal(t, true, connClosed)
}

Here you can see how I tested nvme subsystem with the table approach

[atulpatel261194]

@artek-koltun Sure, i will update the test cases. thank you for the inputs