Fix RFE-4185: run bundle-upgrade with long image names #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunnatsa
force-pushed
the
address-RFE-4185
branch
from
e4b8482
to
35a4b8d
Compare
nunnatsa
force-pushed
the
address-RFE-4185
branch
from
35a4b8d
to
80802e7
Compare
everettraven
approved these changes
Jun 26, 2023
Comment on lines
+178
to
+179
| hashBytes := hash.Sum(nil) | ||
| return fmt.Sprintf("%x", hashBytes) |
There was a problem hiding this comment.
Can we shorten this to something like:
Suggested change
| hashBytes := hash.Sum(nil) | |
| return fmt.Sprintf("%x", hashBytes) | |
| return string(hash.Sum(nil)) |
?
If not this is fine, but I think those are equivalent and doesn't require use of the fmt.Sprintf function
There was a problem hiding this comment.
Thanks for the comment @everettraven - but these two forms are not equivalent. string(hash.Sum(nil)) will try to use the random bytes as characters. The result is unexpected - we'll end up with wrong UTF-8 chars, non-printable chars and so on.
The original format generates a hex string (2 hex digits per byte), which is a safe string.
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
address-RFE-4185
branch
from
80802e7
to
6609632
Compare
sebsoto
added a commit
to sebsoto/release
that referenced
this pull request
Sep 20, 2023
This copies the workflow that is used for the 4.13->4.14 upgrade, using Azure instead of vSphere. Azure is being used as we wish to test storage migration which occurs only for Azure across this upgrade. The operator-sdk version was bumped to include this required fix: operator-framework/operator-sdk#6477 `make update` was ran to generate the presubmit file
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Sep 20, 2023
This copies the workflow that is used for the 4.13->4.14 upgrade, using Azure instead of vSphere. Azure is being used as we wish to test storage migration which occurs only for Azure across this upgrade. The operator-sdk version was bumped to include this required fix: operator-framework/operator-sdk#6477 `make update` was ran to generate the presubmit file
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Jan 25, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Jan 28, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Jan 29, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Jan 30, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Feb 5, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Feb 14, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
jrvaldes
added a commit
to jrvaldes/release
that referenced
this pull request
Feb 16, 2024
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
openshift-merge-bot bot
pushed a commit
to openshift/release
that referenced
this pull request
Feb 16, 2024
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
mshitrit
pushed a commit
to mshitrit/release
that referenced
this pull request
Feb 18, 2024
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
shaior
pushed a commit
to natifridman/release
that referenced
this pull request
Feb 20, 2024
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
sgoveas
pushed a commit
to sgoveas/release
that referenced
this pull request
Feb 22, 2024
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
memodi
pushed a commit
to memodi/release
that referenced
this pull request
Mar 14, 2024
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6476
Description of the change
In
run bundle-upgrade, hash the cache directory name to avoid error of too long file name.Motivation for the change
run bundle-upgradeis failing if the bundle image names are long. See #6476Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs