queueinformer: don't double register informers (#3007)

The abstraction here doesn't let you re-use an informer without also causing it to be re-registered and re-started, which is invalid. Signed-off-by: Steve Kuznetsov <[email protected]>
operator-framework · Aug 8, 2023 · 2be5e58 · 2be5e58
1 parent a7f102a
commit 2be5e58
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/lib/queueinformer/queueinformer_operator.go b/pkg/lib/queueinformer/queueinformer_operator.go
@@ -141,6 +141,12 @@ func (o *operator) RegisterInformer(informer cache.SharedIndexInformer) error {
 }
 
 func (o *operator) registerInformer(informer cache.SharedIndexInformer) {
+	// never double-register an informer
+	for i := range o.informers {
+		if o.informers[i] == informer {
+			return
+		}
+	}
 	o.informers = append(o.informers, informer)
 	o.addHasSynced(informer.HasSynced)
 }