luci-mod-status: split dhcp status in dhcp and dhcpv6 includes #6713
+121
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split dhcp status in separate dhcp and dhcpv6 includes to tidy code up and better organize them instead of defining multiple table and define an empty title for the include file. Signed-off-by: Christian Marangi <[email protected]>
|
error: ReferenceError |
|
|
|
@Ansuel could you address this machints problem please? |
systemcrash
added
feature
|
This will request the DHCP lease information twice and duplicate the processing effort on the server side. If this is touched anyway, I'd propose a radically different way... merge DHCP and DHCPv6 tables (along with potential other information sources such as associated stations, arp and ndp neighbors as well as umdns) into a unified "connected clients/hosts/devices" display. |
|
@jow- would be ok to unify ipv6 and ipv4 for now? To do this we would have to change the ipv4 and ipv6 address column to "Address" and the mac address and DUID to an unified column. Is it correct? |
|
@Ansuel: Have you progressed on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split dhcp status in separate dhcp and dhcpv6 includes to tidy code up and better organize them instead of defining multiple table and define an empty title for the include file.