Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change behavior when changing dates in a datepicker group to be more intuitive. #2583

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Change behavior when changing dates in a datepicker group to be more intuitive. #2583

wants to merge 4 commits into from

Commits on Oct 18, 2024

  1. Change behavior when changing dates in a datepicker group to be more … 

    …intuitive.

Previously when any of the dates were changed, the open, reduced
scoring, close, and answer dates were ensured to be in the correct order
by always changing the input later in the last to a later date if
needed.

This instead acts on the input that was modified.  That input value is
not changed from what the user just changed it to.  Any earlier inputs
in the list are set to the new date in the changed input if they are
later than that date, and any later inputs in the list are set to the
new date in the changed input if they are earlier than that date.

This is to address issue openwebwork#2581.
    @drgrice1
    drgrice1 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ae43a92 View commit details
    Browse the repository at this point in the history

  2. Update the start index of the for loop. 

    Previously the open date was never acted on, and so the for loop started
at one which skipped the open date.  Now it needs to be acted on.
    @drgrice1
    drgrice1 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b4dbd0c View commit details
    Browse the repository at this point in the history

  3. Fix an incorrect index comparison.

    @drgrice1
    drgrice1 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e7b16cc View commit details
    Browse the repository at this point in the history

  4. Fix another minor observed issue. 

    When using the "Today" or "Now" buttons, the "changed" class is not
being added to the input.  When the handlers for those buttons are
called, the "change" event needs to be triggered so that this happens.
    @drgrice1
    drgrice1 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    28557d8 View commit details
    Browse the repository at this point in the history