Merge pull request #637 from didishe90/eventFailOrDropLog

Add more logs to help debug event missing issue
openweave · Jan 12, 2021 · 18d4aef · 18d4aef
2 parents 1dd59be + f2c850a
commit 18d4aef
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/lib/profiles/data-management/Current/LoggingManagement.cpp b/src/lib/profiles/data-management/Current/LoggingManagement.cpp
@@ -1195,6 +1195,10 @@ event_id_t LoggingManagement::LogEvent(const EventSchema & inSchema, EventWriter
 
 exit:
     Platform::CriticalSectionExit();
+    if (event_id == 0)
+    {
+        WeaveLogProgress(EventLogging, "Failed to log event with ProfileId: %d, return event id 0", inSchema.mProfileId);
+    }
     return event_id;
 }
 
@@ -2229,7 +2233,9 @@ void CircularEventBuffer::AddEventUTC(utc_timestamp_t inEventTimestamp)
 
 void CircularEventBuffer::RemoveEvent(size_t aNumEvents)
 {
+    event_id_t currentFirstEventID = mFirstEventID;
     mFirstEventID += aNumEvents;
+    WeaveLogDetail(EventLogging, "Dropping events | Move first event id from %u to %u", currentFirstEventID, mFirstEventID);
 }
 
 /**

diff --git a/src/lib/profiles/data-management/Current/NotificationEngine.cpp b/src/lib/profiles/data-management/Current/NotificationEngine.cpp
@@ -1226,6 +1226,8 @@ WEAVE_ERROR NotificationEngine::BuildSingleNotifyRequestEventList(SubscriptionHa
             event_id_t tmp_id = logger.GetFirstEventID(static_cast<ImportanceType>(i + 1));
             if (tmp_id > initialEvents[i])
             {
+                WeaveLogProgress(DataManagement, "BuildSingleNotifyRequestEventList | Missing event_id range: { %u, %u };",
+                                 initialEvents[i], tmp_id - 1);
                 initialEvents[i] = tmp_id;
             }
         }
@@ -1342,6 +1344,8 @@ WEAVE_ERROR NotificationEngine::BuildSingleNotifyRequestEventList(SubscriptionHa
         if (aSubHandler->mSelfVendedEvents[i] > initialEvents[i])
         {
             event_count += aSubHandler->mSelfVendedEvents[i] - initialEvents[i];
+            WeaveLogProgress(DataManagement, "Fetched events [importance: %d, event_id: %u - %u]",
+                             i, initialEvents[i], aSubHandler->mSelfVendedEvents[i] - 1);
         }
     }