Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow validation #64

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Apr 21, 2024

adds the validation rule back to the cicd

Signed-off-by: Mirko Mollik <[email protected]>
@cre8 cre8 requested a review from samuelmr April 21, 2024 15:59
@cre8
Copy link
Contributor Author

cre8 commented Apr 21, 2024

@samuelmr the validator will check if the wallet files are compliant to the schema.json, not more, not less. So there we need to define all the correct types and required fields.

Copy link
Contributor

@samuelmr samuelmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@samuelmr samuelmr merged commit 2a6626f into openwallet-foundation:main Apr 21, 2024
4 checks passed
@cre8 cre8 deleted the fix/validation branch April 22, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants